You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I quickly looked under the hood of this library because I needed to handle None values in my own dataset, but felt suspicious that this is trying to do something impossible.
I quickly looked under the hood of this library because I needed to handle
None
values in my own dataset, but felt suspicious that this is trying to do something impossible.Looking at https://github.com/msamogh/nonechucks/blob/master/nonechucks/dataset.py#L87-L96, I am under the impression that
__getitem__
will return the same value for multiple indices. E.g. suppose index 2 is None, thendataset[2]
==dataset[3]
.Surely that doesn't make sense for a well-behaved map-style dataset?
Alternatively indices could be remapped via a
Dict[int,int]
for random access.The text was updated successfully, but these errors were encountered: