Linefeed not accepted as newline

[ghost]

If I run the example, I can paste CR or CR+LF lines:

$ ./linenoise_example
hello> expr 5 + 2
echo: 'expr 5 + 2'
hello> expr 5 - 2
echo: 'expr 5 - 2'

but if I try to paste LF lines, I get unexpected result:

$ ./linenoise_example
hello> expr 5 + 2expr 5 - 2
echo: 'expr 5 + 2expr 5 - 2'

[ghost]

Git Bisect reveals this:

15ea795648aa4a4a8aee366914ffe277a5e0c03c is the first bad commit
commit 15ea795648aa4a4a8aee366914ffe277a5e0c03c
Author: Steve Bennett <[email protected]>
Date:   Fri Oct 1 06:07:42 2010 +1000

    Handle control characters in the line

    Only allow tab (^I) to be inserted in the line, not other
    control characters.
    But display any control character as ^x and handle
    the cursor properly.

    Signed-off-by: Steve Bennett <[email protected]>

[ghost]

Note a fork fixed the issue, see linked commit below. It would be added here:

linenoise/linenoise.c

Line 1587 in 174a404

case '\r': /* enter */

[msteveb]

Thanks. That seems reasonable. I don't think there are any downsides. I have added this.