Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove instances of #[allow(clippy::mutable_key_type)] #573

Open
Wodann opened this issue Sep 30, 2024 · 1 comment
Open

Remove instances of #[allow(clippy::mutable_key_type)] #573

Wodann opened this issue Sep 30, 2024 · 1 comment
Labels
exp: intermediate Achievable by experienced contributors, or with some guidance pri: low An issue with no impact to quality, performance, or functionality type: refactor Refactor existing code

Comments

@Wodann
Copy link
Collaborator

Wodann commented Sep 30, 2024

Some of the Mun code is violating the clippy::mutable_key_type lint, but cannot be trivially fixed. Refactor the code to prevent this and remove all instances of #[allow(clippy::mutable_key_type)].

@Wodann Wodann added pri: low An issue with no impact to quality, performance, or functionality exp: intermediate Achievable by experienced contributors, or with some guidance type: refactor Refactor existing code labels Sep 30, 2024
@wackbyte
Copy link
Contributor

wackbyte commented Oct 2, 2024

I say that this is a case of the lint's false positives given that the Hash implementation for Type does not rely on any interior-mutable fields.

(However, changing the keys to perhaps use TypeDataKind directly would probably perform slightly better as the Arc to the data store would not be unnecessarily cloned.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exp: intermediate Achievable by experienced contributors, or with some guidance pri: low An issue with no impact to quality, performance, or functionality type: refactor Refactor existing code
Projects
None yet
Development

No branches or pull requests

2 participants