Merge pull request #25548 from Jojo-Schmitz/4.4.2-xml-title

[4.4.4] Fix GH#24553: MusicXML: A title like "Jazz Piece No. 5" get interpreted as a subtitle
musescore · Nov 21, 2024 · 1f05ce7 · 1f05ce7
2 parents c5c81eb + f8fe8f9
commit 1f05ce7
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 1 deletion.
diff --git a/src/importexport/musicxml/internal/musicxml/importmxmlpass1.cpp b/src/importexport/musicxml/internal/musicxml/importmxmlpass1.cpp
@@ -805,7 +805,11 @@ static void inferFromTitle(String& title, String& inferredSubtitle, String& infe
     StringList subtitleLines;
     StringList creditLines;
     StringList titleLines = title.split(std::regex("\\n"));
-    for (size_t i = titleLines.size(); i > 0; --i) {
+    size_t nrOfTitleLines = titleLines.size();
+    if (nrOfTitleLines == 1) {
+        return;
+    }
+    for (size_t i = nrOfTitleLines; i > 0; --i) {
         String line = titleLines[i - 1];
         if (isLikelyCreditText(line, true)) {
             creditLines.insert(0, line);

diff --git a/vtest/scores/dynamics-10.mscz b/vtest/scores/dynamics-10.mscz
diff --git a/vtest/scores/lyrics-26.mscz b/vtest/scores/lyrics-26.mscz