Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different way of computing context #11

Open
bluesquinn777 opened this issue Jun 22, 2022 · 2 comments
Open

Different way of computing context #11

bluesquinn777 opened this issue Jun 22, 2022 · 2 comments

Comments

@bluesquinn777
Copy link

Hi, many thanks for the excellent code. I got one little question (please feel free to correct me):
In the paper, the authors compute context vector with attention vector * embedded inputs (static and dynamic hidden)

image

But in your code, you applied context vector computation with static hidden only and then cat it with static hidden:

image

I'm a little confused about this. May I ask if there is any particular reasons? Thank you!

@bluesquinn777
Copy link
Author

I mean in you code, it seems that dynamic hidden is ignored for computing context, may I ask the reason? Thanks!

@zhang-xinyuan
Copy link

Hi, I am also confused by this problem,did you solve it?

I mean in you code, it seems that dynamic hidden is ignored for computing context, may I ask the reason? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants