Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SensorAnalogIn - default max-value is 1024 #486

Open
ploeffler opened this issue Jun 14, 2019 · 1 comment
Open

SensorAnalogIn - default max-value is 1024 #486

ploeffler opened this issue Jun 14, 2019 · 1 comment
Labels
bug

Comments

@ploeffler
Copy link

ploeffler commented Jun 14, 2019 •
edited
Loading

(I know it's just a extreme detail ;-) )
the maximum value, you could get out of a 10bit unsigned is 1023 and not, as written in line 33 of SensorAnalogInput 1024

this makes an (more or less significant) eroor when calculating percentage
@user2684 user2684 added the bug label Jun 14, 2019
@user2684
Copy link
Contributor

will fix it! Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ploeffler @user2684