Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isRtl flag reverses text #16

Open
williamjuan027 opened this issue Aug 27, 2020 · 4 comments
Open

isRtl flag reverses text #16

williamjuan027 opened this issue Aug 27, 2020 · 4 comments
Labels
invalid This doesn't seem right

Comments

@williamjuan027
Copy link

isRtl flag when binded to a dynamic value reverses the layout consistently but also reverses the content of the text (the text becomes backwards).

<!-- Breaks -->
<RStackLayout [isRtl]="isRtl">
  <Label text="some text"></Label> <!-- Gets reversed --> 
</RStackLayout>

<!-- Works -->
<RStackLayout></RStackLayout>
<RStackLayout isRtl="false"></RStackLayout>
<RStackLayout isRtl="true"></RStackLayout>

Screenshot
Notice that the text in the above screenshot is reversed

@xlmnxp
Copy link
Member

xlmnxp commented Aug 31, 2020

I will work to embed RTL support to NativeScript main repo

@xlmnxp
Copy link
Member

xlmnxp commented Jun 14, 2021

isRtl flag when binded to a dynamic value reverses the layout consistently but also reverses the content of the text (the text becomes backwards).

<!-- Breaks -->
<RStackLayout [isRtl]="isRtl">
  <Label text="some text"></Label> <!-- Gets reversed --> 
</RStackLayout>

<!-- Works -->
<RStackLayout></RStackLayout>
<RStackLayout isRtl="false"></RStackLayout>
<RStackLayout isRtl="true"></RStackLayout>

Screenshot
Notice that the text in the above screenshot is reversed

is it happen now? text should reversed back

@xlmnxp xlmnxp added the invalid This doesn't seem right label Jun 14, 2021
@boris01
Copy link

boris01 commented Jun 15, 2021

For me, the text gets reversed when I nest some layout inside a RGridLayout
<RGirdLayout [isRtl]="isRtl"> <FlexboxLayout> <Label text="some text"></Label> <!-- Gets reversed --> </FlexboxLayout> </RGridLayout>

@xlmnxp
Copy link
Member

xlmnxp commented Jun 16, 2021

For me, the text gets reversed when I nest some layout inside a RGridLayout
<RGirdLayout [isRtl]="isRtl"> <FlexboxLayout> <Label text="some text"></Label> <!-- Gets reversed --> </FlexboxLayout> </RGridLayout>

for now, @nativescript-rtl/ui not loop to inner components, I will make it loop to nested elements

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

3 participants