Add new Stream Config 2.10 fields #1113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jarema
force-pushed
the
add-new-2_10-fields
branch
from
e728415 to
5ff9c88
Compare
Jarema
force-pushed
the
add-new-2_10-fields
branch
2 times, most recently
from
9fa371b to
45e5711
Compare
Signed-off-by: Tomasz Pietrek <[email protected]>
Jarema
force-pushed
the
add-new-2_10-fields
branch
from
45e5711 to
f608231
Compare
| /// because [Stream] can override global compression set to [Compression::S2] | ||
| /// to [Compression::None], which is different from not overriding global config with anything. | ||
| #[serde(default, skip_serializing_if = "Option::is_none")] | ||
| pub compression: Option<Compression>, |
There was a problem hiding this comment.
I'm trying to figure out how to play with compression while the docs haven't been updated yet and reading this doc comment made me think/wish compression could be enabled globally on the server, which is not how it seems to actually work when looking at the implementation.
I'm now confused about why we have 3 variants (Some(Compression::None), Some(Compression::S2) and None) instead of just Some(Compression::S2) and None or Compression::None and Compression::S2
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tomasz Pietrek [email protected]