Fix for queries that return a small number of series #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… special projects "region")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Special Projects "region" has a small number of OSDs associated with it, and therefore does not use the same procedure involving the "View" window and generated URL for download which all other regions need. Will close #11
This PR implements an alternative solution where the form is filled out with RSelenium (instead of rvest) and the javascript/ASP postback for "download" button is then properly triggered (without needing to generate the actual download URL for a large set).
In the future the rvest code currently used for all other regions could feasibly be converted to this style, simplifying the code in
.query_series_by_region()function--but that is not a super high priority as the current implementation "works" as long as the query tool has this separate pathway for "large" results. We still will need to distinguish large from small queries as different interface is needed for them.