Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fetchSCAN upgrades #184

Closed
7 tasks done
brownag opened this issue May 18, 2021 · 3 comments
Closed
7 tasks done

fetchSCAN upgrades #184

brownag opened this issue May 18, 2021 · 3 comments

Comments

@brownag
Copy link
Member

brownag commented May 18, 2021 •
edited
Loading

brownag added a commit that referenced this issue Oct 12, 2021
@brownag
Fixes broken fetchSCAN(), converting to data.table RE: #161, #184
9d8ce5f
@brownag brownag mentioned this issue Oct 12, 2021
Merged
brownag added a commit that referenced this issue Oct 12, 2021
@brownag
Fixes broken fetchSCAN(), converting to data.table RE: #161, #184
88b2353
brownag added a commit that referenced this issue Feb 11, 2022
@brownag
fetchSCAN updates #184
503ec14 
 - add usage for related methods
 - make SCAN_site_metadata() easier to use
 - better handling of empty results in multi-site queries
brownag added a commit that referenced this issue Aug 9, 2022
@brownag
fetchSCAN() updates
bf8b6da 
 - use ... for additional arguments / related to backwards compatibility with `req` argument (that allowed all request parameters to be customized)
 - for #260, #184
brownag added a commit that referenced this issue Aug 9, 2022
@brownag
Fix extra parameters logic #184/#260
2c41e4a
brownag added a commit that referenced this issue Aug 16, 2022
@brownag
fetchSCAN: Add explicit support for timeseries argument/allow batch…
18f0664 
…ing of hourly data #184, #260

-  Add 'Time' and calculated 'datetime' to batch results #184, #260

-  Update test for new columns

- Docs/urls for cran
@brownag
Copy link
Member Author

brownag commented Aug 16, 2022 •
edited
Loading

A note that now with explicit support for hourly data we should be able to put those data into correct timezone to make accurate datetime objects for data from across multiple timezones.

The StationMetadata should include stationDataTimeZone attribute which can be added to cached SCAN_SNOTEL_metadata data object in the package rather than queried on the fly. This value can be used inside the fetchSCAN internal methods for conversion of each sensor time series within a site
https://www.nrcs.usda.gov/wps/portal/wcc/home/dataAccessHelp/webService/webServiceReference/

stationDataTimeZone BigDecimal The time zone in which the station collects data.

@dylanbeaudette
Copy link
Member

dylanbeaudette commented Mar 31, 2023 •
edited
Loading

An example:

This does not work, but close.

https://wcc.sc.egov.usda.gov/reportGenerator/view_csv/customSingleStationReport,metric/daily/2189:CA:SCAN/%7Cid=%22%22%7Cname/POR_BEGIN,POR_END/TAVG::value

@dylanbeaudette dylanbeaudette mentioned this issue Sep 17, 2024
Closed
dylanbeaudette added a commit that referenced this issue Sep 17, 2024
@dylanbeaudette
add timezone to datetime stamp #184
15cb0f7
@dylanbeaudette dylanbeaudette mentioned this issue Sep 18, 2024
Merged
@dylanbeaudette
Copy link
Member

Sufficiently addressed by merge of #357, will open a new issue (#358) for user-defined TZ. Multiple sensors addressed in own issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dylanbeaudette @brownag