Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: show staged status in gutters and provide a command to unstage chunks (like git.chunkUnstage) #107

Open
Philipp-M opened this issue May 6, 2020 · 5 comments
Labels
enhancement New feature or request

Comments

@Philipp-M
Copy link

While using fugitive with coc-git (great combination btw.), I've noticed it might make sense to show the staged status of lines in the gutter bar as well.
With this feature it might make sense to also integrate a command like git.chunkUnstage.
This allows simple staged-toggling of chunks.

@chemzqm
Copy link
Member

chemzqm commented May 6, 2020

There're git.chunkStage git.chunkUndo commands

@chemzqm chemzqm closed this as completed May 6, 2020
@Philipp-M
Copy link
Author

I know, but git.chunkUndo really undos the chunk (similar as git checkout -p), which seldom is what I want.
And I'm proposing git.chunkUnstage because there is a git.chunkStage. git.chunkUnstage should be more similar as git reset -p.

And to show the user if something is already staged, which makes sense in the context of quickly staging and unstaging chunks, it should be shown in the gutter bar.

Why close this issue so fast?

@chemzqm chemzqm reopened this May 6, 2020
@chemzqm
Copy link
Member

chemzqm commented May 6, 2020

We don't have support for that, PR welcome.

@chemzqm
Copy link
Member

chemzqm commented May 6, 2020

You can undo the change by git.chunkUndo and then git.chunkStage, which should be the same.

@Philipp-M
Copy link
Author

If I do git.chunkUndo, it really is away for me (like git checkout -p), it also isn't working if the chunk is already staged.
But I'll look into this and probably do a PR

@chemzqm chemzqm added the enhancement New feature or request label Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants