Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP starting tag support #37

Open
cprn opened this issue Nov 19, 2019 · 1 comment
Open

PHP starting tag support #37

cprn opened this issue Nov 19, 2019 · 1 comment
Labels
help wanted Extra attention is needed

Comments

@cprn
Copy link

cprn commented Nov 19, 2019

It would be nice for coc-pairs to detect php file type and have a special support for < as the 1st character of the 1st or 2nd line (because 1st line sometimes contains a shebang) that would delete the closing > if the next character is ?.

The issue is whenever I type < at the beginning of a PHP file coc-pairs adds the closing angular bracket > which is not only cumbersome to delete each time the user creates a new class but also prevents some popular (e.g. honza's] PHP snippets from working correctly, e.g. <? expands to the following (notice the closing bracket):

<?php

VISUAL>
@chemzqm chemzqm added the help wanted Extra attention is needed label Nov 20, 2019
@chemzqm
Copy link
Member

chemzqm commented Nov 20, 2019

PR welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants