Skip to content
This repository has been archived by the owner on Feb 1, 2023. It is now read-only.

fix: node copy&past issue [wip] #7

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

Changsik00
Copy link

@Changsik00 Changsik00 commented Jan 31, 2023

resolve: #6

@dazzyjong
WIP로 PR 요청 합니다.

  • 94~97 line: 해당 이슈는 separator가 없어서 생긴 이슈 같아서 textNode 하는 부분에 추가를 해 봤습니다.
  • separator를 class로 그리고 있는데.. 아래 내용은 없어도 되지 않을까 하는데 검토 해봐야 합니다.
separator.setAttribute('src', 'data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAUAAAAVCAYAAACOuSR+AAAAFUlEQVR42mN8P1XsPwMaYBwVHPSCAMuUNqOQ9f+eAAAAAElFTkSuQmCC')
  • 다양한 copy&paste 검수가 필요합니다.
  • 여러 paragraph
  • 외부 텍스트
  • 기타

@Changsik00 Changsik00 requested a review from dazzyjong January 31, 2023 06:44
@Changsik00 Changsik00 self-assigned this Jan 31, 2023
@dazzyjong
Copy link

해준님이 pnpm 머지 할 예정이라, submodule이 monorepo 에서 작업하겠습니다.

@dazzyjong dazzyjong marked this pull request as ready for review January 31, 2023 08:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: TextNode copy&paste issue
2 participants