Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Registry update fails when Device Model property is an array #1160

Merged

Conversation

FrankBakkerNl
Copy link
Contributor

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • The code compiles without warnings (code quality check)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration are added/changed:

Copy link

codecov bot commented Aug 24, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 82%. Comparing base (3713081) to head (ac9608e).
Report is 1 commits behind head on main.

Files Patch % Lines
....HassClient/Internal/Json/EnsureStringConverter.cs 85% 1 Missing ⚠️
Additional details and impacted files
@@         Coverage Diff          @@
##           main   #1160   +/-   ##
====================================
  Coverage    82%     82%           
====================================
  Files       190     189    -1     
  Lines      3782    3777    -5     
  Branches    423     421    -2     
====================================
+ Hits       3116    3121    +5     
+ Misses      499     491    -8     
+ Partials    167     165    -2     
Flag Coverage Δ
unittests 82% <85%> (+<1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@helto4real helto4real merged commit b439aee into net-daemon:main Aug 24, 2024
7 checks passed
@FrankBakkerNl FrankBakkerNl deleted the fix_deserializeHassDeviceModel branch October 24, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants