Make Interfaces of AppModel accessible to Apps so apps can interact with it #931
Conversation
| _applications.Add(app); | ||
| } | ||
|
|
There was a problem hiding this comment.
yea probably a good idea to separate the activation and initialization
There was a problem hiding this comment.
Most important reason was so that all Application objects (not the actual instances) are now created before the first instance is created. Before I did this, in the constructor of the first app the second was not in the list of apps yet
| /// </summary> | ||
| ApplicationState State { get; } |
There was a problem hiding this comment.
We do not want to expose the state as well?
There was a problem hiding this comment.
I am still not sure about what states we should have exactly. I was also playing with two booleans, Enabled and IsRunning. But not sure yet. For the state manager actually only enabled and disabled seem to be relevant.
There was a problem hiding this comment.
aight, seem like somthing we could add in another PR since this has not been public yet
| } | ||
|
|
||
| [NetDaemonApp] | ||
| [Focus] |
There was a problem hiding this comment.
Yeah, will clean up the debug project before merge. It seems like it always has the test code for the most recently added feature
Breaking change
Proposed change
Type of change
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: