Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Module module #983

Open
wants to merge 3 commits into
base: devel
Choose a base branch
from

Conversation

jgroom33
Copy link
Contributor

@jgroom33 jgroom33 commented Apr 18, 2023

Related Issue

#769

New Behavior

  • Add module_interface_template module
  • Add module_bay module
  • Add module Module

Changes to the Documentation

  • module_interface_template
  • module_bay
  • module

Tests

  • module_interface_template module
  • module_bay module
  • module Module

Proposed Release Note Entry

Add module_interface_template module
Add module_bay module
Add module module

Double Check

  • I have read the comments and followed the CONTRIBUTING.md.
  • I have explained my PR according to the information in the comments or in a linked issue.
  • My PR targets the devel branch.

@jgroom33 jgroom33 changed the title WIP Add Module module Apr 18, 2023
@jgroom33
Copy link
Contributor Author

jgroom33 commented Apr 20, 2023

I'm not going to do any further work on this PR. I tried setting up the dev and test environment and it was a pain, so I stopped. I'll leave this PR open in case anyone wants to move it forward more. :) It's working for my use case.

One note: There seems to be a requirement for there to be a user defined key (slug, name, model, etc). The Module component doesn't have an obvious user defined key that could be used. So, I selected asset_tag even though it's not required property, it seemed to fit the purpose.

@bar0n36
Copy link

bar0n36 commented Apr 28, 2023

We would love to see this functionality added, as it seems a bit of a gap. Currently for us to do this, we have to go and manually interact with the REST endpoints via the URI module, so effectively step out of the collection to do a couple of steps, and then step back in to continue (eg: Step 1 we add the device via the netbox_device module, then Step 2 we have to use the URI module to add module bays, Step 3 we have to do other stuff in the netbox collection again)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants