Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Netbox-qrcode plugin request to plugin co-owner #83

Open
LHBL2003 opened this issue Aug 6, 2024 · 4 comments
Open

Netbox-qrcode plugin request to plugin co-owner #83

LHBL2003 opened this issue Aug 6, 2024 · 4 comments

Comments

@LHBL2003
Copy link
Contributor

LHBL2003 commented Aug 6, 2024

Application for code co-owner

Hello @k01ek, (and indirectly also: @cruse1977 and @natm)

i would like to help with the further development of the plugin. Therefore I ask for owner rights like @cruse1977 and @natm have.

Reason

Unfortunately the response times for the pull request are way too slow to be able to help. I had already submitted one a few years ago, which was only recently (I think) taken over. There are 3 code owners who seem to be very busy. I fully understand this, it's always difficult for me too. But since we want to use the plugin in the company, I am very interested in further developing the plugin. Especially so that it works well on label printers.

At the moment I have 2 pull requests ready, which I think are a great extension.

Another pull request will be coming soon, but it is becoming increasingly difficult to keep the branches apart. Because
the bottleneck is always the README.md file. It is also time-consuming to merge all branches into one branch just so that I can continue on the existing basis.

I would even check @cholletk's pull request, as the topic is also relevant for me.


What comes with the next pull request:

  • The label can be specified in mm/inch.
  • Whether printed on an A4 sheet or on a label, the content always has the defined size.
  • The text is razor sharp, no matter how small it is. (Printing the HTML DIV element and its vector text. There is no need to margin the text as an image).
  • All fonts supported by the browser can be used.
  • The barcode can be printed right up to the edge of the label.
  • The size of the QR code can be specified in mm/inch and is exactly the same size on the screen as on the printout.
  • The font height can be specified in mm/inch.
  • The distance between the QR code and the text can be specified in mm/inch.
  • Horizontal and vertical representations are still supported.
  • No scaling or similar has to be changed in the print preview for the printout, it simply always fits.
  • A logo variable can be stored in the Netbox Config, which can be used with the existing text_template function (Jinja2) without losing the overview.
  • One or more label designs can be stored for a model (e.g. device or rack). This allows different label sizes or formats to be used.
  • Only text labels are supported
  • Only QR code labels are supported
  • Text and QR code labels are supported
  • The QR code can be specified higher than wide. (Sometimes looks nice)

This is my first Python and Django project, but I think I can add value to the plugin.
Here is a small preview of what it looks like so far:

A few pictures of my development of the rare 2 days:

I have blurred the logos as this is currently not a dummy logo ;-)

Print preview 56x32

image

Without edge, exactly the same size as the label

image

Change from 56x32 to A4 printer

image

Selection label 10x25mm to 56x32mm label

image

9 different label designs configured for Device. And with racks there is still only 1 layout ;)

image

Here at the same time at the rack (only 1 label, same configuration file)

image

Don't worry, the INIT file will be cleaned up again, but just to see how you can configure multiple labels.

image

Closing words

So I am asking for code co-owner rights to support you.
It's my first Docker, Python and Django project, but I understand the plugin 86% by now :D
When I program it is usually C#, C etc.

Thank you for your time.

@LHBL2003 LHBL2003 changed the title Netbox-qrcode plugin request to plugin owner Netbox-qrcode plugin request to plugin co-owner Aug 6, 2024
@cruse1977
Copy link
Member

cruse1977 commented Aug 10, 2024

Hi @LHBL2003 I can appreciate your frustration here, alongside your interest in the plugin - but I'm not able to provide answer for you on this without consulting others. If you've seen the beta of 4.1 you'll have seen the plugin browser which is now part of NetBox, hence we will be circling back round to plugins as time permits.

For awareness, I've also this branch for the ability to override a URL (one of the FR's) - happy for your thoughts on this one. Not convinced its the best way to achieve (but other ways would require custom fields which isn't ideal either)

If you'll submit the PR, I'm happy to review. Approved the README pr, the vscode will take more time.

Happy to chat async on NetDev slack (I should be easy to find)

@Eto-uo
Copy link

Eto-uo commented Dec 4, 2024

Hi @LHBL2003,

Can you sent me those configuration please.

Thank you

@LHBL2003
Copy link
Contributor Author

LHBL2003 commented Dec 4, 2024

Hello @Eto-uo,

First of all: The examples shown above are not yet included in the main version. But you can test it if you install my developer version. Everything you need for this is described in this pull request (PR):

#84

It describes how to install my version and how to get back to the main version. The README also describes which parameters are available.
There are also 12 sample configurations that you can simply copy into your configuration. Of course, all the examples shown above are also included.

Please create a backup of Configuration.py beforehand, as many new parameters are supported that are not available in the main version.

I would be pleased if you could test many of the 19 improvements listed. Please provide feedback in the PR as to which of the improvements mentioned worked for you. This will help to get the new features into the main version. Because at the moment nobody really has time to check my customisation. Every feedback helps.

Example from my README in the PR.
You can get there via the README.MD file using a link.
Bildschirmfoto 2024-12-04 um 19 41 24

@Eto-uo
Copy link

Eto-uo commented Dec 5, 2024

Hi @LHBL2003,

Thank you for your quick response. Unfortunately, I was unable to install the [Label-Design] plugin you created. Could you please assist me with the installation and configuration process? I need it to print QR code labels in the size 50x25.
Please keep in mind that I’m installing NetBox on Docker within an Ubuntu VM

Thank you in advance for your help!

Best regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants