Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine redundant connections #122

Open
etfz opened this issue Jun 13, 2022 · 4 comments
Open

Combine redundant connections #122

etfz opened this issue Jun 13, 2022 · 4 comments
Labels
status: under review Further discussion is needed to determine this issue's scope and/or implementation type: feature Request for new feature or change to existing feature

Comments

@etfz
Copy link

etfz commented Jun 13, 2022

We have a lot of port channels going on, cluttering the topology. Would be great if there was an option to combine them visually into a single connection. It could be distinguished somehow from regular connections, and include all bundled connection in the tooltip.

@dreng dreng added the type: feature Request for new feature or change to existing feature label Dec 10, 2022
@dreng
Copy link
Collaborator

dreng commented Jan 7, 2023

What you are talking about sounds like logical connections which has been implemented in the meantime. Is it enough for you to hide the cables and display the logical connections instead?

Another approach would be to check in the loop if a cable has been connected already and deny to connect another cable. That would result in a connection with just one representative real cable. This also means that you might double click the one and only cable in order open the cable details, but you would never be able to double click a cable that has been denied to be displayed. This might lead to confusion about the logic itself.

I would not recommend to include all bundled connections in the tooltip, because that might let the tooltip explode (e.g. if there's 50 connections).

@dreng dreng added the status: under review Further discussion is needed to determine this issue's scope and/or implementation label Jan 7, 2023
@candlerb
Copy link

candlerb commented Jan 7, 2023

What you are talking about sounds like logical connections which has been implemented in the meantime. Is it enough for you to hide the cables and display the logical connections instead?

With a port channel (LAG), you still get multiple "logical connections" in Netbox between the physical interfaces.

I previously raised a Netbox feature request where a LAG could have a logical neighbor relationship with a remote LAG, but this was closed: netbox-community/netbox#9401

@dreng
Copy link
Collaborator

dreng commented Mar 30, 2024

A workaround could be #436. If we make smooth type and length an individual setting, you could set it in a way that no dynamic placing of cables is done. You would still have many cables but they look like just one.

@etfz
Copy link
Author

etfz commented Apr 2, 2024

The nature of my concern is primarily a visual one, so that might work, indeed. Though I don't fully understand all the options available. It seems like smooth.enabled = false is what I would want. Frankly, I would prefer to disable physics altogether, as I don't feel it adds anything, except perhaps preventing all nodes getting stacked on top of each other on the initial layout.

I suspect it would not let me see which cables are included, however. The current approach of needing to hover over a bunch of cables is very impractical, regardless.

mattieserver added a commit that referenced this issue Jul 8, 2024
…sics (#488)

* allow disabling smooth cables and render them as straight lines instead

* rename 'disable_smooth_cables' to 'straight_cables'

* missed one in renaming

* fix inverted logic

* add GET param and option to DeviceFilterForm

* fix syntax error

* rename var

* add missing query field

* netbox v4 support

---------

Co-authored-by: Daniel Bremer <[email protected]>
Co-authored-by: mvanhaverbeke <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: under review Further discussion is needed to determine this issue's scope and/or implementation type: feature Request for new feature or change to existing feature
Projects
None yet
Development

No branches or pull requests

3 participants