-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #436 (and #122?): Add options to disable smooth cables and physics #488
Closes #436 (and #122?): Add options to disable smooth cables and physics #488
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you maybe change the name of the vars you added?
Maybe make it 'straight_cables' or something like that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, will merge after testing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have overlooked the saved filters.
api/views.py, line 112 and below
views.py, line 713 and below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have not taken get_query_settings() into account in utils.py.
We need to finish compatibility with NetBox 4.0 first. This PR may need to be rebased after that. |
I will try to test/merge this this weekend. |
Although both issues has status "under review", this maybe makes the decision to accept the issue easier.
PR adds settings to make cable renderings straight lines, as proposed in #436.
Line style is controlled by an option in the "Individual Options".
I am currently working with ~200 hosts and 500+ cables, this change makes the graph a lot clearer in my opinion.
Two side effects:
Fixing the shadows could be done extracting
edges.append(create_edge(...))
calls into a dedicated function and ignoring duplicate connections.