Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cable bulk import when importing circuit terminations #17954

Open
Sergii-Lucky opened this issue Nov 7, 2024 · 9 comments · May be fixed by #17995
Open

Cable bulk import when importing circuit terminations #17954

Sergii-Lucky opened this issue Nov 7, 2024 · 9 comments · May be fixed by #17995
Assignees
@jsenecal
Labels
severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@Sergii-Lucky
Copy link

Deployment Type

Self-hosted

Triage priority

I volunteer to perform this work (if approved)

NetBox Version

v.4.1.6

Python Version

3.12

Steps to Reproduce

When trying to use the bulk cable import feature to import cables with circuit terminations, I'm getting the error "Record 1 side_a_device: Object not found:397718".

To reproduce:
I have an existing device NTT-ODF1 with a port X01.
I have an existing circuit, 397718 and I'm trying to connect to Termination A

Import data:
side_a_device,side_a_type,side_a_name,side_b_device,side_b_type,side_b_name
397718,circuits.circuittermination,A,NTT-ODF1,dcim.rearport,X01

Expected Behavior

Should be able to import cables connected to circuit terminations.

Observed Behavior

Screenshot 2024-11-07 at 16 50 17 Screenshot 2024-11-07 at 16 46 55 Screenshot 2024-11-07 at 16 46 22
@Sergii-Lucky Sergii-Lucky added status: needs triage This issue is awaiting triage by a maintainer type: bug A confirmed report of unexpected behavior in the application labels Nov 7, 2024
@bctiemann bctiemann added severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation labels Nov 8, 2024 — with Linear
@bctiemann bctiemann removed the status: needs triage This issue is awaiting triage by a maintainer label Nov 8, 2024
@jsenecal
Copy link
Contributor

I noticed the same today. I have found the culprit and would be willing to submit a fix for it @bctiemann @Sergii-Lucky,

_clean_side is missing the use-case of circuitterminations and this could probably be added easily.

If @Sergii-Lucky would like me to take this issue, just let me know and I'll start working on a fix.

@Sergii-Lucky
Copy link
Author

@jsenecal
Yes, of course.
Let me know if you need additional information or any help from my side.

@jeremystretch
Copy link
Member

Thanks @jsenecal, I've assigned this to you.

jsenecal added a commit to jsenecal/netbox that referenced this issue Nov 12, 2024
@jsenecal
Fixes netbox-community#17954 - Handle CircuitTerminations in Cable Bu…
2721455 
…lk Import
@jsenecal jsenecal linked a pull request Nov 12, 2024 that will close this issue
Open
@sleepinggenius2
Copy link
Contributor

While this is being fixed for circuit terminations, I believe there is currently a similar issue for Power Feed type terminations, which should probably also be addressed.

@jsenecal
Copy link
Contributor

While this is being fixed for circuit terminations, I believe there is currently a similar issue for Power Feed type terminations, which should probably also be addressed.

This is another issue with a similar fix. Can you link the issue so I can submit a different PR @sleepinggenius2 ?

@sleepinggenius2
Copy link
Contributor

I'm not aware of a Github issue opened for that at this time. Can it be included as part of this one or should I open a new one and link it here?

@Sergii-Lucky
Copy link
Author

I'm not aware of a Github issue opened for that at this time. Can it be included as part of this one or should I open a new one and link it here?

Please open a new one.
I am not sure if it's necessary to link it here.

@sleepinggenius2
Copy link
Contributor

I have opened #18008 for the power feed use case.

@jsenecal jsenecal mentioned this issue Nov 14, 2024
Open
@jsenecal
Copy link
Contributor

@jeremystretch, not sure if you noticed but I submitted a PR for this bug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsenecal jsenecal

Labels
severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #17954 - Handle CircuitTerminations in Cable Bulk Import jsenecal/netbox
5 participants
@jsenecal @bctiemann @jeremystretch @sleepinggenius2 @Sergii-Lucky