fix quotes

netfoundry · Nov 27, 2024 · c7956eb · c7956eb
1 parent 8e0c550
commit c7956eb
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 13 deletions.
diff --git a/.github/workflows/pr.yaml b/.github/workflows/pr.yaml
@@ -138,8 +138,8 @@ jobs:
               publicAccess: true
               privateAccess: true
           EOF
-          eksctl get clusters  --region $AWS_REGION -o json
-          STATUS="$(eksctl get clusters --region $AWS_REGION -o json \
+          eksctl get clusters  --region "$AWS_REGION" -o json
+          STATUS="$(eksctl get clusters --region "$AWS_REGION" -o json \
             | jq -r --arg cluster_name "$CLUSTER_NAME" \
               '.[] | select(.name=="$cluster_name").Status'
           )"
@@ -388,18 +388,13 @@ jobs:
               https://gateway.production.netfoundry.io/core/v3/networks \
               --header 'Content-Type: application/json" \
               --header "Authorization: $token_type $token")"
-          echo NF_NETWORK_ID="$(
-            echo "$network_list" \
-            | jq -r --arg nf_network_name "$NF_NETWORK_NAME" \
-              '._embedded.networkList[]
-              | select(.name=="$nf_network_name").id'
-          )" | tee -a $GITHUB_ENV
           export network_id="$(
             echo "$network_list" \
             | jq -r --arg nf_network_name "$NF_NETWORK_NAME" \
               '._embedded.networkList[]
               | select(.name=="$nf_network_name").id'
           )"
+          echo NF_NETWORK_ID="$network_id" | tee -a $GITHUB_ENV
           export zt_token="$(
             curl  --silent --fail --location --request POST \
               https://gateway.production.netfoundry.io/core/v3/networks/"$network_id"/exchange \
@@ -746,7 +741,7 @@ jobs:
             curl --silent --fail --location --request POST \
               https://netfoundry-production-xfjiye.auth.us-east-1.amazoncognito.com/oauth2/token \
               --header 'Content-Type: application/x-www-form-urlencoded' \
-              --user '${{ secrets.NF_API_CLIENT_ID_FOR_GITHUB }}:${{ secrets.NF_API_CLIENT_PW_FOR_GITHUB }}' \
+              --user "${{ secrets.NF_API_CLIENT_ID_FOR_GITHUB }}:${{ secrets.NF_API_CLIENT_PW_FOR_GITHUB }}" \
               --data-urlencode 'grant_type=client_credentials'
           )"
           export token="$(echo $RESPONSE | jq -r .access_token)"
@@ -764,7 +759,7 @@ jobs:
           )" | tee -a $GITHUB_ENV
           export network_status="$(
             curl --silent --fail --location --request DELETE \
-              https://gateway.production.netfoundry.io/core/v3/networks/$NF_NETWORK_ID \
+              https://gateway.production.netfoundry.io/core/v3/networks/"$NF_NETWORK_ID" \
               --header 'Content-Type: application/json' \
               --header "Authorization: $token_type $token"
             )"

diff --git a/.gitignore b/.gitignore
@@ -23,7 +23,5 @@
 # build dir
 /build
 
-#config files
-
-/nf_identity_*.pem
+# local temp files
 /ziti-agent.yaml