Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support states for changefeeds #541

Open
neumino opened this issue Aug 7, 2016 · 1 comment
Open

Support states for changefeeds #541

neumino opened this issue Aug 7, 2016 · 1 comment
Labels

Comments

@neumino
Copy link
Owner

neumino commented Aug 7, 2016

Now thinky is silently dropping them. We should figure out a way to surface these.

@xfg
Copy link

xfg commented Aug 7, 2016

Also the problem is this that the AtomFeed doesn't work properly with includeStates: true because that the result.next gets the {state: 'initializing'} message or {state: 'ready'} message if the includeInitial: false instead of query result https://github.com/neumino/thinky/blob/master/lib/query.js#L180

and also unhandled exception will be within document.js because feed.each gets the {state: 'initializing'} or {state: 'ready'} messages and runs self._merge(undefined) at line 1773 and then within Document#_merge tries to handle undefined[key] at line 1723 and as a result gets the unhandled exception.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants