feat: clean bindings #ntrn-410 #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NeverHappened
force-pushed
the
feat/clean-bindings
branch
from
95b9162 to
f7f850c
Compare
NeverHappened
force-pushed
the
feat/clean-bindings
branch
from
ea82b8b to
1420a74
Compare
This was referenced Oct 16, 2024
sotnikov-s
requested changes
Oct 27, 2024
contracts/dex_grpc/src/contract.rs
Outdated
| order_type, | ||
| expiration_time, | ||
| max_amount_out, | ||
| min_average_sell_price: "".to_string(), // TODO |
There was a problem hiding this comment.
todo what? and by whom? same request re such comments as in neutron-sdk PR
There was a problem hiding this comment.
forgot to check it.
removed the todo, since empty string is okay:
// If min_average_sell_price is omitted limit_sell_price will be used instead
sotnikov-s
approved these changes
Oct 29, 2024
pr0n00gler
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove bindings and related code from neutron-sdk ,neutron-dev-contracts and integration tests
https://hadronlabs.atlassian.net/browse/NTRN-410
PR's: