java-lotto step2 #3265
Open
java-lotto step2 #3265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nokchax
requested changes
May 31, 2023
Comment on lines
+24
to
+27
| @Override | ||
| public String toString() { | ||
| return lottoBuyCount + "개를 구매했습니다.\n" + lottoTickets; | ||
| } |
There was a problem hiding this comment.
도메인(model) 내부에 출력(view)과 관련된 로직이 들어가 있으면 안 돼요
model 과 view 를 분리해주세요~!
| private final int lottoBuyCount; | ||
|
|
||
| LottoBuyCount(int buyPrice) { | ||
| this.lottoBuyCount = buyPrice / LOTTO_PRICE; |
| public class LottoNumberGenerator { | ||
|
|
||
| public List<Integer> generateLottoNumbers() { | ||
| List<Integer> lottoNumbers = new ArrayList<>(); |
There was a problem hiding this comment.
1부터 45 까지의 lottoNumber 도 LottoNumber 클래스로 래핑해주세요~!
| } | ||
|
|
||
| public Map<Integer, Integer> calculateLottoWinStatistics(LottoWinNumber lottoWinNumber) { | ||
| Map<Integer, Integer> resultMap = new HashMap<>(); |
There was a problem hiding this comment.
변수명에 컬렉션 이름(list, map, set 등)을 사용하지 말아주세요, 객체지향적인 사고를 저해하는 요소입니다.
| } | ||
|
|
||
| public Map<Integer, Integer> calculateLottoWinStatistics(LottoWinNumber lottoWinNumber) { | ||
| Map<Integer, Integer> resultMap = new HashMap<>(); |
|
|
||
| import java.util.Map; | ||
|
|
||
| public class LottoWinStatistics { |
There was a problem hiding this comment.
로또 결과는 일치하는 갯수와 당첨금으로 구성되어 있습니다.
이는 변하지 않는 값인데요 enum으로 구현해보면 어떨까요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
잘 부탁드립니다.
감사합니다. 😌