Step2 - 로또(자동) #3786
Open
Step2 - 로또(자동) #3786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javajigi
requested changes
Apr 23, 2024
| public static void main(String[] args) { | ||
| // 사용자로부터 구매 금액 입력받기 | ||
| String purchaseAmount = readInput("구입금액을 입력해 주세요."); | ||
| int purchaseCount = calculateTicketCount(purchaseAmount); |
There was a problem hiding this comment.
원시 값을 포장하는 원칙을 시도해 보는 것은 어떨까?
| printPurchaseTickets(purchaseCount); | ||
|
|
||
| // 로또 자동 생성 및 출력 | ||
| List<List<Integer>> tickets = generateTickets(purchaseCount); |
There was a problem hiding this comment.
2중으로 콜렉션을 쓰기보다 가능하면 객체로 포장해 하나의 콜렉션을 사용할 것을 추천
List를 객체로 포장하는 것은 어떨까?
| public static final int LOTTO_PRICE = 1000; | ||
| private static final int LOTTO_COUNT = 6; | ||
| private static final int LOTTO_MAX = 45; | ||
|
|
There was a problem hiding this comment.
클래스 메서드로 구현하지 않고 List을 인스턴스 변수로 가지는 객체로 구현하는 것은 어떨까?
Comment on lines
+20
to
+24
| List<Integer> numbers = new ArrayList<>(); | ||
|
|
||
| for (int i = 1; i <= LOTTO_MAX; i++) { | ||
| numbers.add(i); | ||
| } |
There was a problem hiding this comment.
이와 같이 구현할 경우 로또를 생성할 때마다 45개의 값을 콜렉션에 담아야 한다.
그 보다 45개의 값을 가지는 콜렉션을 재사용하는 방식으로 구현하는 것은 어떨까?
| return result; | ||
| } | ||
|
|
||
| public static List<Integer> parse(String input) { |
There was a problem hiding this comment.
이 메서드는 두 가지 이상의 일을 하고 있다.
메서드가 한 가지 일만 하도록 리팩터링해 보면 어떨까?
| import static lotto.domain.Lotto.LOTTO_PRICE; | ||
| import static lotto.domain.Lotto.matchCount; | ||
|
|
||
| public enum LottoPrize { |
Comment on lines
+89
to
+105
| List<Integer> winningNumbers = List.of(1, 2, 3, 4, 5, 6); | ||
| List<List<Integer>> purchasedTickets = Arrays.asList( | ||
| List.of(8, 21, 23, 41, 42, 43), | ||
| List.of(3, 5, 11, 16, 32, 38), | ||
| List.of(7, 11, 16, 35, 36, 44), | ||
| List.of(1, 8, 11, 31, 41, 42), | ||
| List.of(13, 14, 16, 38, 42, 45), | ||
| List.of(7, 11, 30, 40, 42, 43), | ||
| List.of(2, 13, 22, 32, 38, 45), | ||
| List.of(23, 25, 33, 36, 39, 41), | ||
| List.of(1, 3, 5, 14, 22, 45), | ||
| List.of(5, 9, 38, 41, 43, 44), | ||
| List.of(2, 8, 9, 18, 19, 21), | ||
| List.of(13, 14, 18, 21, 23, 35), | ||
| List.of(17, 21, 29, 37, 42, 45), | ||
| List.of(3, 8, 27, 30, 35, 44) | ||
| ); |
There was a problem hiding this comment.
테스트 fixture 구현부가 너무 크다.
로또 당첨 결과만을 가지는 객체를 만들고 이 객체가 수익률을 계산하도록 구현하는 것은 어떨까?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.