[step4] 로또 (수동) #1123
Open
[step4] 로또 (수동) #1123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsh123
requested changes
Dec 10, 2024
| @@ -50,4 +50,15 @@ object LottoController { | |||
| ) | |||
| return result | |||
| } | |||
|
|
|||
| private fun createMyLottoList(totalLottoCount: Int): List<Lotto> { | |||
| val manualLottoCount = InputView.readManualLottoCount(InputView.ENTER_MANUAL_LOTTO_COUNT) | |||
There was a problem hiding this comment.
InputView에 InputView의 메시지를 넣어주는 방식으로 변경하신 이유가 있을까요~?
프롬프트 메시지는 View의 영역이라고 생각해서요!
| private fun readManualLotto(): List<Int> { | ||
| val input = | ||
| readlnOrNull()?.trim() | ||
| ?.split(",") |
| val input = | ||
| readlnOrNull()?.trim() | ||
| ?.split(",") | ||
| ?.map { it.trim().toIntOrNull() ?: 0 } |
There was a problem hiding this comment.
OrNull 이후에 throw가 아닌 0으로 결정하신 이유가 있을까요??
View에서 숫자가 아닌경우의 validation은 해줘도 되지 않을까싶어요!
| promptMessage: String, | ||
| count: Int, | ||
| ): List<List<Int>> { | ||
| val manualLottoNumberList = mutableListOf<List<Int>>() |
There was a problem hiding this comment.
https://tecoble.techcourse.co.kr/post/2020-04-24-variable_naming/
네이밍에 대해 고민해보고 List postfix를 붙이는 것에 대한 고민을 해보면 어떨까요?
| } | ||
|
|
||
| private fun autoGeneratedLottoList() = | ||
| List(autoGeneratedLottoCount) { |
There was a problem hiding this comment.
autoGeneratedLottoCount가 음수가 될 확률은 없을까요!?
| } | ||
| } | ||
|
|
||
| private fun autoGeneratedLottoList() = |
There was a problem hiding this comment.
중괄호 없이 단일 표현식으로 작성을 해주셨는데요!
단일 표현식으로 작성하시는 기준이 있을까요~?
| @@ -23,8 +23,8 @@ object LottoController { | |||
| // 총 구매 로또 개수 | |||
| ResultView.printTotalPurchaseCount(totalLottoCount) | |||
|
|
|||
| val myLottoList = createMyLottoList(totalLottoCount) | |||
There was a problem hiding this comment.
당첨번호라는 의미를 가진 변수인데, myLotto가 괜찮을기 고민 해보면 좋을 것 같아요 :)
| @@ -1,4 +1,4 @@ | |||
| package lotto.domain.model | |||
| package lotto.domain | |||
|
|
|||
| @JvmInline | |||
| value class Lotto(val value: List<LottoNumber>) { | |||
There was a problem hiding this comment.
지금보니까 LottoTest가 없네요!! 테스트를 작성해보면 어떨까요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
피드백 미리 감사드립니다.