Step2 로또(자동) #1124
Open
Step2 로또(자동) #1124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsh123
requested changes
Dec 10, 2024
| object InputView { | ||
| fun getUserAmount(): Int { | ||
| println("구입 금액을 입력해 주세요.") | ||
| val amount: String = readln() |
| fun getUserAmount(): Int { | ||
| println("구입 금액을 입력해 주세요.") | ||
| val amount: String = readln() | ||
| return amount.toInt() |
There was a problem hiding this comment.
toIntOrNull을 활용해서, 숫자가 아닌경우에 대한 처리를 해보면 어떨까요?
| import lotto.domain.LottoTickets | ||
| import lotto.domain.WinningLotto | ||
|
|
||
| class LottoController { |
| companion object { | ||
| const val LOTTO_TICKET_PRICE = 1000 | ||
|
|
||
| fun purchase(amount: Int): LottoTickets { |
Comment on lines
35
to
38
| val lottoTickets = ArrayList<LottoTicket>() | ||
| repeat(quantity) { | ||
| lottoTickets.add(LottoTicket.generateLottoNumber()) | ||
| } |
There was a problem hiding this comment.
Suggested change
| val lottoTickets = ArrayList<LottoTicket>() | |
| repeat(quantity) { | |
| lottoTickets.add(LottoTicket.generateLottoNumber()) | |
| } | |
| val lottoTickets = List(quantity) { LottoTicket.generateLottoNumber()} |
위 처럼 작성이 가능해 보여요! :)
| } | ||
|
|
||
| companion object { | ||
| const val LOTTO_TICKET_PRICE = 1000 |
| _tickets = lottoTickets | ||
| } | ||
|
|
||
| fun calculateLottoRank(winningLotto: WinningLotto): LottoResults { |
There was a problem hiding this comment.
해당 테스트가 Controller에 있지만, Tickets에도 단위테스트를 만들어 검증해보면 어떨까요?
| @@ -0,0 +1,42 @@ | |||
| package lotto.domain | |||
|
|
|||
| class LottoTickets(lottoTickets: List<LottoTicket>) : Collection<LottoTicket> by lottoTickets { | |||
There was a problem hiding this comment.
위임을 활용하셨군요!! 👍 다만 lottoTickets은 생성자의 인자일뿐 프로퍼티가 아닌데요!
프로퍼티를 기반으로 위임을 진행해야 하지 않을까요?
| @Test | ||
| fun `로또 티켓을 생성하면 6개의 번호가 들어있다`() { | ||
| val lottoTicket = LottoTicket.generateLottoNumber() | ||
| lottoTicket.lottoNumbers.size shouldBe 6 |
| fun `로또 티켓을 구입 금액에 맞게 발급한다`() { | ||
| val amount = 5_000 | ||
| val lottoTickets = LottoTickets.purchase(amount) | ||
| lottoTickets.tickets.size shouldBe 5 |
There was a problem hiding this comment.
위임을 사용했다면 아래와 같이 사용이 가능해보여요 :)
Suggested change
| lottoTickets.tickets.size shouldBe 5 | |
| lottoTickets shouldHaveSize 5 |
1. 타입추론 이용으로 자료형 제거 2. 구입금액 숫자가 아닌 경우 처리
1. repeat 연산자를 List 사용하도록 변경
1. LottoTickets 프로퍼티를 기반으로 위임하도록 변경 2. LottoTicket 위임을 유지하면서 생성자 값 명시적인 변환
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요
자동 로또 리뷰 부탁드립니다.