🚀 2단계 - 지뢰 찾기(지뢰 개수) #345
Open
🚀 2단계 - 지뢰 찾기(지뢰 개수) #345
+198
−107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ohgillwhan
requested changes
Jul 15, 2023
Comment on lines
+16
to
+25
| class MineSquare() : GameBoardSquare(0) { | ||
| override fun isMine(): Boolean = true | ||
| } | ||
|
|
||
| override fun hashCode(): Int { | ||
| return squareValueType.hashCode() | ||
| class NumberSquare(numOfNearByMine: Int) : GameBoardSquare(numOfNearByMine) { | ||
| override fun isMine(): Boolean = false | ||
|
|
||
| companion object { | ||
| fun createEmpty(): NumberSquare = NumberSquare(numOfNearByMine = 0) | ||
| } |
| require(squareValueType == SquareValueType.EMPTY) { "게임판을 초기화 할 때는 지뢰가 되면 안됩니다." } | ||
| } | ||
| sealed class GameBoardSquare(val numOfNearByMine: Int) { | ||
| abstract fun isMine(): Boolean |
There was a problem hiding this comment.
GameBoardSquare 는 Mine 타입까지 이미 고려하고 있는것 같네요!
그것 때문에 NumberSquare도 MineSquare과 논리적으로 엮일려는거 같아요.
Comment on lines
14
to
15
| require(x in (startIndexOfBoard..board.first().size)) { "생성된 지뢰의 x좌표는 게임판 범위에 포함되어야 합니다." } | ||
| require(y in (startIndexOfBoard..board.size)) { "생성된 지뢰의 y좌표는 게임판 범위에 포함되어야 합니다." } |
There was a problem hiding this comment.
startIndexOfBoard와 board.first().size, board.size는 무슨 의미를 가지고 있는지 알기 어렵네요!
| } | ||
|
|
||
| private fun isLocationInIndexOfBoard(board: List<List<GameBoardSquare>>, mineLocation: MineLocation) { | ||
| val (x, y) = mineLocation.location | ||
| private fun isLocationInIndexOfBoard(board: List<List<GameBoardSquare>>, squareLocation: SquareLocation) { |
There was a problem hiding this comment.
is로 시작하니, 리턴이 boolean 일것 같네요! require같은 이름은 어떨까요?
| val generatedMineLocation = mineLocationGenerator.generateMineLocation(getBoard()) | ||
| insertMine(generatedMineLocation) | ||
| val (x, y) = mineLocationGenerator.generateMineLocation(mutableBoard) | ||
| mutableBoard[y][x] = GameBoardSquare.MineSquare() |
There was a problem hiding this comment.
이 부분에서 이미 지뢰를 생성하고 있네요! 그럼 이 클래스 내에서 지뢰(MineSquare)를 담고 있는 List를 만들어서 관리해주면 GameBoardSquare에 isMine은 고민해볼 필요가 있겠어요!
| @@ -0,0 +1,54 @@ | |||
| package minesweeper.domain | |||
|
|
|||
| object MineCounter { | |||
|
|
||
| object MineCounter { | ||
|
|
||
| fun initMineCounts(mutableBoard: MutableList<MutableList<GameBoardSquare>>): List<List<GameBoardSquare>> { |
Comment on lines
+45
to
+53
| private fun isNewLocationInBoardBound( | ||
| newLocation: SquareLocation, | ||
| board: List<List<GameBoardSquare>> | ||
| ) = newLocation.x in board.indices && newLocation.y in board[newLocation.x].indices | ||
|
|
||
| private fun isNewLocationIsMine( | ||
| board: List<List<GameBoardSquare>>, | ||
| newLocation: SquareLocation | ||
| ) = board[newLocation.x][newLocation.y].isMine() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요!
말씀해주신 불변을 지키는 것을 목표로 코드를 만들어봤습니다~
잘 부탁드리겠습니다 🙏🏻