-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve styles for accessibility #1054
Comments
[edit: I want to make super clear that any curtness and aggressive tone in this comment is aimed at our styles and not at the particular words used or the yellow fever dataset or anyone in particular. I wrote it while off the clock and annoyed at how hard it was to read this text, which I wanted to read! 🙏] There is some text on nextstrain.org that's just too damn hard to read. Not sure if it'll come thru well in a screenshot, but this was very difficult to get thru and comes off as needlessly like "fine print" that I'm not intended to read. |
We're talking about the styling. This is an issue about the styling. The issue talks about font weights, text colors, and background colors. This is what I'm also talking about. That the screenshot is of text you wrote is merely coincidental (not personal!). I was trying to read it, found the styling hindered that for me, knew we had an open issue about these styles, and so came here to record a concrete example of the issue. |
Sorry, I was responding to what was in the email I clicked on, and I didn't appreciate the existing context. Thanks for expanding that, apologies if my reply was snarky. Practically speaking, is there any reason to not |
Not sure! That feels like it might make some parts look janky, but @victorlin or @jameshadfield might have a better idea without having to go digging. I think Victor's suggestions at the top to consider all three styling properties (weight, color, bgcolor) are good. His example screenshots are from a blog post, which has a different current styling than the dataset footer text I screenshotted. The footer text is Lato 300 |
+1 for changing 300 to 400 in most places. Maybe not for some text in the footer such as nextstrain.org/static-site/components/footer/index.tsx Lines 54 to 67 in a0cde63
|
I think just getting rid of the |
Considerations for dyslexia:
Many text elements, such as paragraphs in blog posts, use a thin dark gray font on a pure white background:
Some of those factors could impair readability. Adjusting with
color: black
font-weight: 400
background-color: #f5f6f7
is arguably more readable (and maybe only a subset of those changes is sufficient):These styles should be considered simultaneously:
Font color
#333
for some elements.Font weight
Background color
This is unset at the base level, meaning the browser default (
transparent
) is used.Note: Some elements rely on
transparent
for implicit inheritance. This means setting abackground-color
at the base level needs work to remove the implicit inheritance. Example of what happens when setting a basebackground: white
:(others?)
Links
The text was updated successfully, but these errors were encountered: