Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(util): fix _isVendor name collisions #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Merott
Copy link

@Merott Merott commented Jun 10, 2014

Match the file names including the preceding / to account for similar files names. For example,
Restangular.js would collide with angular.js, but /Restangular.js will not collide with
/angular.js.

This fixes most cases of name collision, unless there are two files with exact same names from
different libraries. This is much less likely, but not impossible.

There must be a better way of checking if a reference is to a vendor file!

Match the file names including the preceding `/` to account for similar files names. For example,
`Restangular.js` would collide with `angular.js`, but `/Restangular.js` will not collide with
`/angular.js`.

This fixes most cases of name collision, unless there are two files with exact same names from
different libraries. This is much less likely, but not impossible.

There must be a better way of checking if a reference is to a vendor file!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant