Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for a custom hostname validator #25

Open
zsteinkamp opened this issue Jul 18, 2023 · 0 comments
Open

Allow for a custom hostname validator #25

zsteinkamp opened this issue Jul 18, 2023 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@zsteinkamp
Copy link
Contributor

From @ivanitskiy:

here is an idea for you. let's have a callback on the client so users/developers can build their own validators (say they want to have allow list).
from: https://github.com/auto-ssl/lua-resty-auto-ssl

auto_ssl:set("allow_domain", function(domain, auto_ssl, ssl_options, renewal)
  return ngx.re.match(domain, "^(example.com|example.net)$", "ijo")
end)

we can provide a default callback but allow people to make their own validations.

@ivanitskiy ivanitskiy added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants