Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider consolidating on one ASN.1 reader vs maintaining two #46

Open
rmhrisk opened this issue Jan 18, 2024 · 0 comments
Open

Consider consolidating on one ASN.1 reader vs maintaining two #46

rmhrisk opened this issue Jan 18, 2024 · 0 comments

Comments

@rmhrisk
Copy link

rmhrisk commented Jan 18, 2024

Is your feature request related to a problem? Please describe

No.

Describe the solution you'd like

We are the authors of PKI.js and ASN.1js and were looking at projects that took a dependency on our libraries so I started looking at consumers like njs-acme.

We noticed that you import ASN.js but implement your own ASN.1 reader.

image

Though we didn't see any issues in your ASN.1 reader we also didn't look very closely. In general, parsers are a pain to get right and since you take the dependency and use it in some places you could make a relatively simple change to reduce to complexity of your code by using our reader in all places vs maintaining two implementations as a dependency.

Describe alternatives you've considered

This is just a suggestion.

Additional context

N/A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant