From 92cc251ffa84b937bff86886c49d2fa0aadbc6a9 Mon Sep 17 00:00:00 2001 From: Mason Le Date: Mon, 11 Jul 2022 11:28:52 +0700 Subject: [PATCH] feat: change app icon by env --- README.md | 4 +--- template/README.md | 4 +--- template/commitlint.config.js | 2 +- template/env/.dev | 1 + template/env/.prod | 1 + template/ios/HelloWorld.xcodeproj/project.pbxproj | 4 ++-- 6 files changed, 7 insertions(+), 9 deletions(-) diff --git a/README.md b/README.md index 2448de8f..43a1feba 100644 --- a/README.md +++ b/README.md @@ -30,9 +30,7 @@ - Android [Source sets](https://developer.android.com/studio/build/build-variants#sourcesets) - IOS follow below step: - Create new App Icon assets - - Go to Target => Build Settings => Assets Catalog Compiler - Options - - Change Primary App Icon Set Name (App Icon assets name) - - This will change icon for current schema + - Change ASSETCATALOG_COMPILER_APPICON_NAME to your respective App Icon Assets (in respective env file) ## :arrow_forward: Usage diff --git a/template/README.md b/template/README.md index 77b53cec..9a138954 100644 --- a/template/README.md +++ b/template/README.md @@ -44,6 +44,4 @@ - Android [Source sets](https://developer.android.com/studio/build/build-variants#sourcesets) - IOS follow below step: - Create new App Icon assets - - Go to Target => Build Settings => Assets Catalog Compiler - Options - - Change Primary App Icon Set Name (App Icon assets name) - - This will change icon for current schema + - Change ASSETCATALOG_COMPILER_APPICON_NAME to your respective App Icon Assets (in respective env file) diff --git a/template/commitlint.config.js b/template/commitlint.config.js index 1e13a0f5..d9dabd4c 100644 --- a/template/commitlint.config.js +++ b/template/commitlint.config.js @@ -11,7 +11,7 @@ module.exports = { 'never', ['sentence-case', 'start-case', 'pascal-case', 'upper-case'], ], - 'scope-enum': [2, 'always', ['mobile', 'backend', 'frontend', 'docs']], + 'scope-enum': [2, 'always', ['ios', 'android', 'all', 'docs']], 'scope-empty': [2, 'never'], 'subject-empty': [2, 'never'], 'subject-full-stop': [2, 'never', '.'], diff --git a/template/env/.dev b/template/env/.dev index 08e91e7e..c47d09ff 100644 --- a/template/env/.dev +++ b/template/env/.dev @@ -5,6 +5,7 @@ APP_PLACEHOLDER_NAME=HelloWorld VERSION_CODE=1 VERSION_NAME=1.0.0 BUNDLE_IDENTIFIER=com.helloworld +ASSETCATALOG_COMPILER_APPICON_NAME=AppIcon DEBUG_PROVISIONING_PROFILE=com_helloworld RELEASE_PROVISIONING_PROFILE=com_helloworld_appstore DEFAULT_FALLBACK_LNG_I18n=en \ No newline at end of file diff --git a/template/env/.prod b/template/env/.prod index 9f8e56f0..6cd76dfd 100644 --- a/template/env/.prod +++ b/template/env/.prod @@ -5,6 +5,7 @@ APP_PLACEHOLDER_NAME=HelloWorld VERSION_CODE=1 VERSION_NAME=1.0.0 BUNDLE_IDENTIFIER=com.helloworld +ASSETCATALOG_COMPILER_APPICON_NAME=AppIcon DEBUG_PROVISIONING_PROFILE=com_helloworld RELEASE_PROVISIONING_PROFILE=com_helloworld_appstore DEFAULT_FALLBACK_LNG_I18n=en \ No newline at end of file diff --git a/template/ios/HelloWorld.xcodeproj/project.pbxproj b/template/ios/HelloWorld.xcodeproj/project.pbxproj index 8f7d625f..ae8045a8 100644 --- a/template/ios/HelloWorld.xcodeproj/project.pbxproj +++ b/template/ios/HelloWorld.xcodeproj/project.pbxproj @@ -541,7 +541,7 @@ isa = XCBuildConfiguration; baseConfigurationReference = 3B4392A12AC88292D35C810B /* Pods-HelloWorld.debug.xcconfig */; buildSettings = { - ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon; + ASSETCATALOG_COMPILER_APPICON_NAME = "$(ASSETCATALOG_COMPILER_APPICON_NAME)"; CLANG_ENABLE_MODULES = YES; CURRENT_PROJECT_VERSION = 1; ENABLE_BITCODE = NO; @@ -569,7 +569,7 @@ isa = XCBuildConfiguration; baseConfigurationReference = 5709B34CF0A7D63546082F79 /* Pods-HelloWorld.release.xcconfig */; buildSettings = { - ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon; + ASSETCATALOG_COMPILER_APPICON_NAME = "$(ASSETCATALOG_COMPILER_APPICON_NAME)"; CLANG_ENABLE_MODULES = YES; CURRENT_PROJECT_VERSION = 1; INFOPLIST_FILE = HelloWorld/Info.plist;