-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
numjs not compatible with vitejs bundler #107
Comments
I made a forked @d4c/numjs package, and there are three output formats inside.
import nj from 'https://cdn.jsdelivr.net/npm/@d4c/numjs/build/module/numjs.min.js'; // or <script type="module">
import nj from 'https://cdn.jsdelivr.net/npm/@d4c/numjs/build/module/numjs.min.js';
<script> It is a work-around way. I may improve it later since using |
i tried and worked, is a shame though cause this will load the hole library in the broewser, whereas with importing specific modules, when building, it will only bundle the code that is being used. anyways, not much of a big deal, numjs is not that heavy |
The issue is some ndarray related packages uses by numjs are not designed for tree-shakable and use some Node.js library/CommonJS inside. So it needs at least some bundler/transpiler to do some things. It takes some time to config/refacor them (polyfill or mock), either on numjs package side or the bundler/transpiler side of the numjs user. |
Would be great if you guys make numjs compatible with vitejs (which is insanely fast).
I just created a blank project and just try to add it in the main.js file like so:
browser shows this error:
thanks a lot
The text was updated successfully, but these errors were encountered: