Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Obsolete abbreviation for Hebrew #251

Open
deg opened this issue Jan 2, 2024 · 0 comments
Open

Obsolete abbreviation for Hebrew #251

deg opened this issue Jan 2, 2024 · 0 comments

Comments

@deg
Copy link

deg commented Jan 2, 2024

  • deep_translator version: 1.11.4
  • Python version: 3.11
  • Operating System: MacOS

Description

Translation to Hebrew fails when target = "he"

What I Did

I tried to use GoogleTranslator with a target of Hebrew.
Passing in "hebrew" works fine, but "he" was not recognized.
Nicely, the error message gave enough details for me to see that "iw" was expected (and does work).

I've never seen "iw" used for Hebrew. A bit of Googling found that it was the standard until 1989 (!!)
https://xml.coverpages.org/iso639a.html

I can work around this easily enough, but it would be great if you could add support for "he". For compatibility, I guess you should also retain "iw" to avoid breaking existing users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant