added thrown error for duplicate testcases in describe instance #4302
Conversation
testcases have a 1 to 1 relation with functions so each test name should map to one function only, can't map to multiple functions in the same describeInstance
|
|
|
@badra022 Thanks for this PR. Could you please sign the CLA as well? |
|
just signed it, thanks @garg3133 |
Status
|
|
This is potentially a breaking change because while it does run fine in the serial mode -- stops the test run with an error that is easily actionable, it just altogether skips the test suite during a parallel run without reporting any error in the HTML report. This is not ideal (and breaking) because the tests which were running earlier no longer run and it's not very straightforward for the user to know that a few tests stopped running. Would need to spend some more time on this to figure out how the error can be better reported during a parallel run. |
lib/testsuite/context.js
Outdated
| const {Logger} = Utils; | ||
|
|
||
| const err = new Error( | ||
| 'An error occurred while loading the testsuite:\n' + | ||
| `A testcase with name "${testName}" already exists. Testcases must have unique names inside the test suite, ` + | ||
| 'otherwise testcases with duplicate names might not run at all.\n\n' + | ||
| 'This testsuite has been disabled, please fix the error to run it properly.' | ||
| ); | ||
| Logger.error(err); | ||
|
|
||
| this.setAttribute('@disabled', true); |
There was a problem hiding this comment.
This acts more like a warning than throwing the error and exiting the process, while also making sure the faulty testsuite is disabled and the user sees it in the report.
|
@badra022 Does this look like an acceptable solution? |
Description
duplicate testcases inside describe instance that have same testName runs only the second test function for each time, this behavior should not be allowed so the user should have a thrown error explaining this to make test names inside the describe suite unique
Proof of work
here it shows the error when you write two tests with the same name inside the describe test suite
Thanks in advance for your contribution. Please follow the below steps in submitting a pull request, as it will help us with reviewing it quicker.
examples/testsdirectory of the project) and running them.ecosia.jsandduckDuckGo.jsare good examples to work with.features/my-new-featureorissue/123-my-bugfix);