Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reaction improvements #63

Open
2 of 11 tasks
kiliankoe opened this issue Apr 3, 2020 · 5 comments
Open
2 of 11 tasks

Reaction improvements #63

kiliankoe opened this issue Apr 3, 2020 · 5 comments
Labels
enhancement New feature or request

Comments

@kiliankoe
Copy link
Member

kiliankoe commented Apr 3, 2020

  • The emoji picker should show a full list of emoji (see Grid based Emoji Picker #159).
  • Visible reactions on a message should be interactable.
    • Send existing emoji by tapping on them.
    • "Unsending" (redacting) already sent emoji.
    • They're also way too small currently.
  • Show info on reactions (who sent what).
  • Reactions are rather small with a very small system font size.
  • Visible reactions should be sorted by date received, not string order.
    • Possibly remove count for emoji that have only been sent once
  • Support emoji shortcodes (e.g. :+1:)
  • Custom emotes


Just for reference, here's what Slack's and Signal's (this probably isn't possible with the current context menu APIs) emoji picker looks like.

@kiliankoe kiliankoe added the enhancement New feature or request label Apr 3, 2020
@regexident
Copy link
Collaborator

It would also be nice to support named emoji (e.g. :+1: for 👍🏻).

@regexident
Copy link
Collaborator

I guess we'll want to wait for Apple to introduce a SwiftUI equivalent for UICollectionView first, though. 😅

@kiliankoe
Copy link
Member Author

Yeah, I was trying to build the picker on top of a bunch of UICollectionView-esque SwiftUI libs, to no avail. It's pretty much contained, so we could just use a normal collection view, but I'm fairly certain Apple is bringing us something in this regard next month. It's just too big of a thing not to support in SwiftUI.

Another thing that's been bugging me is how some emoji get shown as their "classic unicode representation" and not as emoji, like ☝️ and ☝.

Wow, even GitHub normalizes it! This is what it looks like during editing:
Screen Shot 2020-05-28 at 20 59 42

It's super ugly. Riot iOS has the same issue.
Rob Napier held a cool talk at UIKonf last week and one part was probably applicable to this. We could try adding a variation selector to the relevant reactions.

Screen Shot 2020-05-18 at 20 04 29

kiliankoe added a commit that referenced this issue Jun 27, 2020
regexident pushed a commit that referenced this issue Jul 1, 2020
@regexident
Copy link
Collaborator

There really should be an official emoji picker in both, UIKit and SwiftUI. 😕

@kiliankoe
Copy link
Member Author

I've submitted feedback for some API for (efficiently) working with emoji data. Nobody wants to maintain that list... Slack hasn't updated theirs in months and every similar app has to do the same. Emoji are bundled with OS updates on Darwin platforms and should be accessible that way as well.

regexident pushed a commit that referenced this issue Jul 1, 2020
kiliankoe added a commit that referenced this issue Jul 1, 2020
kiliankoe added a commit that referenced this issue Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants