Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh actions settup with cachix and nur-update heroku app only runs if not <YOUR_something_NAME> #38

Open
06kellyjac opened this issue Jan 26, 2021 · 1 comment

Comments

@06kellyjac
Copy link

The GH actions config changed from:
if: ${{ matrix.cachixName != '' }}
to:
if: ${{ matrix.cachixName != '<YOUR_CACHIX_NAME>' }}
with the nur-update step having a similar update

Should it's behavior be to always set up cachix and trigger nur-update as long as there is a value?
Or should it only enable cachix for a specific cachix cache as you'll only have one secret key in secrets.CACHIX_SIGNING_KEY

Should there be separate cachix setups? One for a main cachix with CACHIX_SIGNING_KEY and one for the rest?

I'm guessing most users will only have 1 cachixName and one nurRepo in the matrix so that might be overkill

related commit: 52d63e8

06kellyjac referenced this issue Jan 26, 2021
in case someone forgets to update those
@06kellyjac 06kellyjac changed the title gh actions use of cachix and nur-update heroku app gh actions settup with cachix and nur-update heroku app only runs if not <YOUR_something_NAME> Jan 26, 2021
@bignaux
Copy link

bignaux commented Mar 14, 2021

An issue with if: ${{ matrix.cachixName != '<YOUR_CACHIX_NAME>' }} , is that people tend to modify it since we use to complete <VAR> without more thought. On 46 github action configured nur, 6 put their cachix name, 9 removes it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants