Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When frank QUITs, people may get regreeted after he rejoins #32

Open
Merovius opened this issue Dec 1, 2016 · 0 comments
Open

When frank QUITs, people may get regreeted after he rejoins #32

Merovius opened this issue Dec 1, 2016 · 0 comments

Comments

@Merovius
Copy link
Collaborator

Merovius commented Dec 1, 2016

Currently, the following can happen:

a) frank shuts down
b) user who has been inactive for a while PARTs or QUITs
c) frank rejons
d) user rejons
e) user gets greeted, because they got expunged from the lastSeen list due to inactivity and frank didn't see the QUIT

As frank now keeps state over who is in which channel, we could use that information to inform greetings, instead of only refreshing the list when things get posted. We might get away with only using the member-list, but there might be corner cases I'm not thinking of. Using both, in any way, would make greetings strictly more reliable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant