You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As I've mentioned in nodejs/node#55993 (comment). Let's use this issue to discuss the next steps of create-release-proposal.yml.
We have run it with success for the last v22.x proposal nodejs/node#56040 and now it's time to improve it.
Issues
1 - Since the script is using actions/checkout to checkout the staging branch it becomes a problem if you don't cherry-pick all create-release-proposal.yml commits to the staging branch as it will run an outdated version (and in the case of v20, it doesn't have the action yet). It's necessary to be in the staging branch to run git node release --prepare, so a possible resolution would be:
1 - Run actions/checkout on main and copy the ./tools/create-release.sh content
2 - Run actions/checkout on staging branch
3 - Run the copied ./tools/create-release.sh instead of local create-release.sh
But I don't know if I like this approach. Any suggestion?
2 - Attribution of work to the releaser. All the work is now attributed to the bot, ideally we can keep authorship attribution in at least three diff places:
1 - The user handler that gets add to the PR description title, along with the user handler added to the doc/changelogs/CHANGELOG_V<version>.md file needs to point to the handler of the current release manager for that proposal
2 - The PR should ideally be opened on behalf of the release manager
3 - The release commit authorship needs to be properly attributed to the release manager
The text was updated successfully, but these errors were encountered:
As I've mentioned in nodejs/node#55993 (comment). Let's use this issue to discuss the next steps of
create-release-proposal.yml
.We have run it with success for the last v22.x proposal nodejs/node#56040 and now it's time to improve it.
Issues
actions/checkout
to checkout the staging branch it becomes a problem if you don't cherry-pick allcreate-release-proposal.yml
commits to the staging branch as it will run an outdated version (and in the case of v20, it doesn't have the action yet). It's necessary to be in the staging branch to rungit node release --prepare
, so a possible resolution would be:actions/checkout
on main and copy the./tools/create-release.sh
contentactions/checkout
on staging branch./tools/create-release.sh
instead of local create-release.shBut I don't know if I like this approach. Any suggestion?
doc/changelogs/CHANGELOG_V<version>.md
file needs to point to the handler of the current release manager for that proposalThe text was updated successfully, but these errors were encountered: