Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create-release-proposal Roadmap #1061

Open
2 tasks
RafaelGSS opened this issue Nov 27, 2024 · 2 comments
Open
2 tasks

create-release-proposal Roadmap #1061

RafaelGSS opened this issue Nov 27, 2024 · 2 comments

Comments

@RafaelGSS
Copy link
Member

RafaelGSS commented Nov 27, 2024

As I've mentioned in nodejs/node#55993 (comment). Let's use this issue to discuss the next steps of create-release-proposal.yml.

We have run it with success for the last v22.x proposal nodejs/node#56040 and now it's time to improve it.

Issues

  • 1 - Since the script is using actions/checkout to checkout the staging branch it becomes a problem if you don't cherry-pick all create-release-proposal.yml commits to the staging branch as it will run an outdated version (and in the case of v20, it doesn't have the action yet). It's necessary to be in the staging branch to run git node release --prepare, so a possible resolution would be:
    • 1 - Run actions/checkout on main and copy the ./tools/create-release.sh content
    • 2 - Run actions/checkout on staging branch
    • 3 - Run the copied ./tools/create-release.sh instead of local create-release.sh
      But I don't know if I like this approach. Any suggestion?
  • 2 - Attribution of work to the releaser. All the work is now attributed to the bot, ideally we can keep authorship attribution in at least three diff places:
    • 1 - The user handler that gets add to the PR description title, along with the user handler added to the doc/changelogs/CHANGELOG_V<version>.md file needs to point to the handler of the current release manager for that proposal
    • 2 - The PR should ideally be opened on behalf of the release manager
    • 3 - The release commit authorship needs to be properly attributed to the release manager
@ruyadorno
Copy link
Member

ruyadorno commented Nov 27, 2024

Added "attribution of work" to the discussion since that's a major departure that I noticed from using the GH Action.

@RafaelGSS
Copy link
Member Author

Added "attribution of work" to the discussion since that's a major departure that I noticed from using the GH Action.

To fix that I believe we just need to find a way to get the release username and email and replace them on https://github.com/nodejs/node/blob/main/.github/workflows/create-release-proposal.yml#L77. Possibly this is already available via GitHub workflow variables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants