Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate flaky test-watch-mode-inspect #44805

Closed
tniessen opened this issue Sep 27, 2022 · 4 comments · Fixed by #45060
Closed

Investigate flaky test-watch-mode-inspect #44805

tniessen opened this issue Sep 27, 2022 · 4 comments · Fixed by #45060
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. macos Issues and PRs related to the macOS platform / OSX. watch-mode Issues and PRs related to watch mode

Comments

@tniessen
Copy link
Member

Test

test-watch-mode-inspect

Platform

macOS x64

Console output

10:41:02 not ok 3788 sequential/test-watch-mode-inspect
10:43:02   ---
10:43:02   duration_ms: 120.129
10:43:02   severity: fail
10:43:02   exitcode: -15
10:43:02   stack: |-
10:43:02     timeout
10:43:02     TAP version 13
10:43:02     (node:3988) ExperimentalWarning: The test runner is an experimental feature. This feature could change at any time
10:43:02     (Use `node --trace-warnings ...` to show where the warning was created)
10:43:02   ...

Build links

Additional information

More flakiness from the watch mode.

Refs: #44655
Refs: #44735
@tniessen tniessen added the flaky-test Issues and PRs related to the tests with unstable failures on the CI. label Sep 27, 2022
@github-actions github-actions bot added the macos Issues and PRs related to the macOS platform / OSX. label Sep 27, 2022
@tniessen
Copy link
Member Author

@MoLow this was one of the most frequent failures today.

@MoLow
Copy link
Member

MoLow commented Sep 29, 2022

checking. sorry for the delayed response, we had our holidays this week

@MoLow MoLow mentioned this issue Sep 30, 2022
Open
@MoLow
Copy link
Member

MoLow commented Sep 29, 2022

it seems like it was one of the most frequent failures due to the report counting failures incorrectly, I am still looking for a fix anyway

@MoLow MoLow mentioned this issue Oct 2, 2022
Merged
@tniessen tniessen mentioned this issue Oct 5, 2022
Open
nodejs-github-bot pushed a commit that referenced this issue Oct 10, 2022
@MoLow
test: debug watch mode inspect
0298b7f 
PR-URL: #44861
Refs: #44805
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Erick Wendel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit that referenced this issue Oct 11, 2022
@MoLow @danielleadams
test: debug watch mode inspect
b9b671f 
PR-URL: #44861
Refs: #44805
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Erick Wendel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MoLow
Copy link
Member

MoLow commented Oct 18, 2022

the full output with logs: https://ci.nodejs.org/job/node-test-commit-osx/nodes=osx1015/48035/console

not ok 3800 sequential/test-watch-mode-inspect
  ---
  duration_ms: 120.103
  severity: fail
  exitcode: -15
  stack: |-
    timeout
    [test] Connecting to a child Node process
    [test] Testing /json/list
    TAP version 13
    [err] (node:10346) ExperimentalWarning: Watch mode is an experimental feature. This feature could change at any time
    [err] (Use `node --trace-warnings ...` to show where the warning was created)
    [err] 
    [err] Debugger listening on ws://127.0.0.1:54291/0f69e497-659d-4d62-a7e5-4b93a72d0d56
    [err] For help, see: https://nodejs.org/en/docs/inspector
    [err] 
    [err] Debugger attached.
    [err] 
    [out] safe to debug now
    [out] 
    [test] Connecting to a child Node process
    [test] Testing /json/list
    [err] Debugger ending on ws://127.0.0.1:54291/0f69e497-659d-4d62-a7e5-4b93a72d0d56
    [err] For help, see: https://nodejs.org/en/docs/inspector
    [err] 
  ...

@MoLow MoLow added the watch-mode Issues and PRs related to watch mode label Oct 18, 2022
@MoLow MoLow mentioned this issue Oct 18, 2022
Merged
nodejs-github-bot pushed a commit that referenced this issue Oct 22, 2022
@MoLow
test: watch mode inspect restart repeatedly
47b63f5 
PR-URL: #45060
Fixes: #44805
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: James M Snell <[email protected]>
RafaelGSS pushed a commit that referenced this issue Nov 1, 2022
@MoLow @RafaelGSS
test: watch mode inspect restart repeatedly
9a146ba 
PR-URL: #45060
Fixes: #44805
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: James M Snell <[email protected]>
RafaelGSS pushed a commit that referenced this issue Nov 10, 2022
@MoLow @RafaelGSS
test: watch mode inspect restart repeatedly
2b3b291 
PR-URL: #45060
Fixes: #44805
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit that referenced this issue Dec 30, 2022
@MoLow @danielleadams
test: watch mode inspect restart repeatedly
35903e6 
PR-URL: #45060
Fixes: #44805
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit that referenced this issue Dec 30, 2022
@MoLow @danielleadams
test: watch mode inspect restart repeatedly
bdf7f25 
PR-URL: #45060
Fixes: #44805
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit that referenced this issue Jan 3, 2023
@MoLow @danielleadams
test: watch mode inspect restart repeatedly
a8030b9 
PR-URL: #45060
Fixes: #44805
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. macos Issues and PRs related to the macOS platform / OSX. watch-mode Issues and PRs related to watch mode
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: watch mode inspect restart repeatedly MoLow/node
2 participants
@tniessen @MoLow