Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The order in which plugins handle events is not consistent, depending on how they're specified #397

Open
sirosen opened this issue May 12, 2018 · 1 comment
Labels

Comments

@sirosen
Copy link
Collaborator

sirosen commented May 12, 2018

Based on #396 , plugin load order determines the order in which events are handled.
As a result, specifying a plugin via command line arguments vs via config file results in different executions, and may actually change the results or mask subtle plugin interaction bugs.

If possible, the order of plugin execution should be consistent.
Easy (hopefully viable) solution: after all plugins are loaded, sort them alphabetically by module name. That is their execution order.

@sirosen sirosen added the bug label May 12, 2018
@katrinabrock
Copy link
Collaborator

Agree this is a problem worth solving. Providing the user a way to specify plugin execution order for non-built in plugins might be nice too, but at least having consistent ordering is definitely better than the status quo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants