Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maybe simplify Plugin architecture to get rid of PluginMeta #434

Open
sirosen opened this issue Mar 30, 2019 · 0 comments
Open

Maybe simplify Plugin architecture to get rid of PluginMeta #434

sirosen opened this issue Mar 30, 2019 · 0 comments

Comments

@sirosen
Copy link
Collaborator

sirosen commented Mar 30, 2019

I'm considering this after looking into an issue and coming across a comment from JP about this.
Blame shows this as having been in 9ba06f1 .

While once upon a time it might have been possible to hold out hope for unittest2 plugins, I think the time for that has passed.

While such a change could in theory break 3rd party plugins, I think it might be worth it / worth considering. It just means that anyone with a plugin with an __init__ method needs to make sure they call super().__init__.

Some of nose2's own plugins have initializers which don't call the superclass initializer, so imitators may exist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant