Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: todo block #27

Closed
wants to merge 2 commits into from
Closed

feat: todo block #27

wants to merge 2 commits into from

Conversation

Moon-DaeSeung
Copy link
Contributor

Description of Changes

Here is reference: #25


support 'custom your created block' block

add todo block

Review point

could this component be more sementic? (regarding tag and aria-attribute)

To reproduce

  • npm run story:start
  • click 'your created block' on the Storybook left side panel

Screenshot

스크린샷 2024-09-23 오후 11 29 25

Review Guide

Reviews are conducted based on priority levels, such as p0, p1, p2, p3, p4, and p5.
p0 ~ p2: If the author decides not to reflect a review for p0 to p2, it signals that a proper discussion with the reviewer is
necessary. It is expected that the review will be resolved either through incorporating the feedback or through further discussion.
p3: indicates that the reviewer has identified a significant issue, but either lacks a clear solution or the comment lacks sufficient context. Further explanation or additional discussion on the reviewer's concerns is needed.
p4, p5: p4 and p5 suggest low priority, and if the author does not deem them important, these comments can be disregarded.

@Moon-DaeSeung Moon-DaeSeung added the enhancement New feature or request label Sep 24, 2024
@jiji-hoon96
Copy link

I tried working on #39
If I knew what you did first... I would have done something different... Too bad!
To avoid this kind of confusion, why don't we make a list of what needs to be done in an issue and synchronize it?
I checked out your component and it extends Todo for child elements as well... great idea!

@Moon-DaeSeung
Copy link
Contributor Author

@jiji-hoon96

Thank you for your contribution and the effort you've put into this PR! I really appreciate your work.

I apologize for the confusion. I had actually been working on a similar implementation and had just submitted a PR for it. This situation highlights an important point about our project communication.

To avoid such overlaps in the future and to better synchronize our efforts, we're planning to implement a new system for sharing ongoing work and intentions. We'll be using an approach similar to the one described in this issue: Nextjs-kr/Nextjs.kr#1

This will help us all stay informed about what others are working on and allow for better coordination.

Regarding this PR, while it would typically be fair to merge the PR that came in first, in this case, I'll withdraw my PR and we'll proceed with yours. I noticed you extended the Todo component for child elements as well - that's a great idea!

Thank you again for your contribution and your patience as we work to improve our collaboration processes. Your input and ideas are valuable to this project, and I look forward to more of your contributions in the future!

@Moon-DaeSeung Moon-DaeSeung deleted the feat-todo branch October 3, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants