-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NounsAuctionHouseV2 - BidWithComment Upgrade #755
Open
EricDevito
wants to merge
41
commits into
nounsDAO:master
Choose a base branch
from
EricDevito:bidwithcomment
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…monorepo into bidwithcomment
EricDevito
changed the title
BidWithComment upgrades from Lil Nouns DAO
NounsAuctionHouseV2 - BidWithComment Upgrade
Dec 25, 2023
Sync With Master & Small Tweaks
…monorepo into bidwithcomment
Export Auction House V2 to Fix Application Error
Upgrade to mainnet subgraph required before merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tl;dr - Vote With Reason for auction bids.
This upgrade gives bidders the option to leave a comment alongside their bid - preferably reasons for why they'd like to become lil nouner, what they'd add to the community, or why and how a particular lil noun caught their eye.
PR includes: