Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NounsAuctionHouseV2 - BidWithComment Upgrade #755

Open
wants to merge 41 commits into
base: master
Choose a base branch
from

Conversation

EricDevito
Copy link
Contributor

@EricDevito EricDevito commented Jul 12, 2023

tl;dr - Vote With Reason for auction bids.

This upgrade gives bidders the option to leave a comment alongside their bid - preferably reasons for why they'd like to become lil nouner, what they'd add to the community, or why and how a particular lil noun caught their eye.

PR includes:

  • AuctionHouse.sol and IAuctionHouse.sol upgrades
  • UI changes to surface bid comments for past /current auctions and allow bidders to provide an optional comment with their bids, with gas calculated per byte.
  • @nouns-subgraph update to surface comments from bid events
  • @nouns-bots upgrade to surface comments on bid event

@EricDevito EricDevito changed the title BidWithComment upgrades from Lil Nouns DAO NounsAuctionHouseV2 - BidWithComment Upgrade Dec 25, 2023
@EricDevito
Copy link
Contributor Author

Upgrade to mainnet subgraph required before merge.
Also, testing here (sepolia): https://master--stellular-cat-047478.netlify.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants