DRAFT: require noun age to fork #806
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
age is counted in noun ids
davidbrai
commented
Oct 11, 2023
| @@ -216,6 +220,11 @@ library NounsDAOV3Fork { | |||
| return ds.forkEscrow.numTokensInEscrow(); | |||
| } | |||
|
|
|||
| function checkNounIdIsAllowedToFork(NounsDAOStorageV3.StorageV3 storage ds, uint256 tokenId) internal view { | |||
| uint256 auctionedNounId = INounsAuctionHouseV2(ds.nouns.minter()).auction().nounId; | |||
| if (tokenId < auctionedNounId - ds.nounAgeRequiredToFork) revert NounIdNotOldEnough(); | |||
There was a problem hiding this comment.
gas: worth reading ds.nounAgeRequiredToFork and auctionedNounId once for all the tokens
davidbrai
commented
Oct 12, 2023
packages/nouns-contracts/contracts/governance/fork/NounsDAOV3Fork.sol
Outdated
Show resolved
Hide resolved
eladmallel
force-pushed
the
verbs-require-noun-age-to-fork
branch
from
e990e8d to
a042c33
Compare
they used to mint by pranking as minter but with the new noun age logic we need to increment noun ID on auction so tests are now minting via auctions instead of pranking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.