Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update pre-commit hooks #886

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Conversation

pre-commit-ci[bot]
Copy link
Contributor

@pre-commit-ci pre-commit-ci bot commented Dec 3, 2024

updates:
- [github.com/astral-sh/ruff-pre-commit: v0.7.2 → v0.8.1](astral-sh/ruff-pre-commit@v0.7.2...v0.8.1)
- [github.com/astral-sh/uv-pre-commit: 0.4.29 → 0.5.5](astral-sh/uv-pre-commit@0.4.29...0.5.5)
Copy link

github-actions bot commented Dec 3, 2024

Binder 👈 Launch a binder notebook on this branch for commit 6e2a9a1

I will automatically update this comment whenever this PR is modified

@mfisher87
Copy link
Collaborator

The version bump of the uv hooks is not what is causing them to fail. I'm not sure why it started only recently. The cause is pre-commit.ci not permitting Internet access at runtime. I think we need to add the --offline arg. But we only want to use that in the CI context, not locally. Not sure the best way to address it.

@mfisher87 mfisher87 merged commit ffbfddd into main Dec 3, 2024
8 of 9 checks passed
@mfisher87 mfisher87 deleted the pre-commit-ci-update-config branch December 3, 2024 16:39
Copy link

github-actions bot commented Dec 6, 2024

User ayushnag does not have permission to run integration tests. A maintainer must perform a security review of the code changes in this pull request and re-run the failed integration tests jobs, if the code is deemed safe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant