Skip to content
This repository has been archived by the owner on Aug 17, 2023. It is now read-only.

Sort PR from jessemiller repository and see which ones we want to merge #10

Open
Psycojoker opened this issue Oct 14, 2016 · 1 comment

Comments

@Psycojoker
Copy link
Collaborator

Currently, there are 9 PR that we haven't merged yet, those are:

Added {% hamlpy %} jinja2 tag, with tests and documentation jessemiller#160

I don't use jinja2 with django so I'm not really interested but this doesn't seems very heavy to maintain.

Change regexp search method jessemiller#158 which fixes jessemiller#126

I think that this one is still relevant and could be merged.

[DONE] Add call and macro tags to the self-closing dict jessemiller#155

I've just merged it since it was small and relevant.

Python-style conditional constructs in attribute dictionaries jessemiller#148

I have mixed feelings about this one. I think that this extends haml beyond it's original goal and this patch doesn't work anymore since we have switch of parser behavior. I don't know it it's worth it over {% if condition %}a{% else %}b{% endif %}.

:sass filter for YAML-like CSS styling https://github.com/jessemiller/HamlPy/pull/143/files

I don't uses sass but this one could be neat and looks quite simple.

{% include %} template tags do not work with non-VALID_EXTENSIONS https://github.com/jessemiller/HamlPy/pull/121/files

Again, looks simple and worth it.

added compact notation for dynamic attributes jessemiller#109

I have mixed feelings about this one and I don't think that this work anymore. Also the codegen dependency seems unmaintained now.

web2py support / inline coffeescript tags https://github.com/jessemiller/HamlPy/pull/19/files

I have no opinion about web2py (is it still used?), coffeescript tag seems neat.

No hurry about discussing those nor merging those at all, I just wanted to have them listed somewhere

@rowanseymour
Copy link
Member

My 2 cents on these:

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants