Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update display file of the substituted compendium "in place" #122

Open
3 tasks
nuest opened this issue Dec 14, 2017 · 2 comments
Open
3 tasks

Update display file of the substituted compendium "in place" #122

nuest opened this issue Dec 14, 2017 · 2 comments

Comments

@nuest
Copy link
Member

nuest commented Dec 14, 2017

After a substitution is created, it is not enought to simply run a job. Instead, the files in the substituted compendium must be updated. At least the display file will be different if a different data file is used.

This could happen by starting a job "in place", or by copying the files back to the compendium directory. In any case, this requires a specific type of job that only shares some steps with a regular job.
Required steps probably are image prepare, image build, image run, and copy file.

This job is started by the substituter.
muncher and informer should just as well work for providing read access and live updates for these kinds of jobs.

  • update API
    • jobs with type "overwrite"/"create_substitution"/... are not listed under /jobs
    • /jobs allows to filter to show only specific types, by default the type is "regular"/"check"/...
    • after creating a substitution it is a candidate compendium
    • if there is an error during the creation job, the compendium stays a candidate
    • if a compendium is candidate AND substituted: true, then...
      • the response does not contain the files property (because the files are not updated yet; but there is no access control to the files, a client may construct the URLs using file names from the base compendium..)
  • create issue in muncher for job types and filters (update the job model!)
  • implement & test

With all this in place, the substituter can then provide a comparison between base display file and substitution display file, see #121

@MarkusKonk
Copy link

MarkusKonk commented Dec 14, 2017

User clicks on substitution

The user receives information that:
Files are substituted
The analysis has started/running/finished (including logs)

"Go to ERC" possible once the analysis is finished

What happens if the user closes the browser and comes back?
Assuming that the analysis continues in the background:
The list of compendia includes "substitution candidates" (different from normal candidates) which are currently running ERCs that emerged from a substitution.
A click on them shows a popup/window with the current logs. The user can see which step is currently ongoing.
This is the same if the analysis of the ERC failed. The user can see which step failed but does not get to the ERC view.
We provide the user with a notification that the ERC will appear in the list once the analysis is finished.

@nuest
Copy link
Member Author

nuest commented Jul 23, 2018

Should the substituted files not also be displayed to the user? I.e. the client shows the substituted and original files both in the listing and potentially with some side-by-side view (which could even solve #121)

@nuest nuest transferred this issue from o2r-project/o2r-substituter Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants