Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use the undici shim for Node #675

Open
vixalien opened this issue Oct 1, 2024 · 1 comment
Open

Don't use the undici shim for Node #675

vixalien opened this issue Oct 1, 2024 · 1 comment

Comments

@vixalien
Copy link

vixalien commented Oct 1, 2024

When compiling for Node.js, the package uses undici to shim for Request/Response, etc.. however, this causes issues in production, when using code that checks for response instanceof Response or similar.

Because the response got is not an actual Response, it causes issues. I think undici should be dropped since the fetch API is supported in Node.js 18+

@kitsonk
Copy link
Collaborator

kitsonk commented Nov 23, 2024

Since oak migrated to JSR, it no longer uses undici and we have stopped publishing the npm package.

You can use more recent versions of oak under Node.js via the package published on JSR like:

npx jsr add @oak/oak

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants